DATAREDIS-1195 - Make putIfAbsent atomic when TTL is set #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugflux
commented
Jul 30, 2020
bugflux
commented
- You have read the Spring Data contribution guidelines.
- There is a ticket in the bug tracker for the project in our JIRA.
- You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
- You submit test cases (unit or integration tests) that back your changes.
- You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
|
@bugflux Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@bugflux Thank you for signing the Contributor License Agreement! |
|
I'm not sure what kind of test to capture this change with. I'll be happy to add one if you share a preference |
bugflux
changed the title
bugflux
force-pushed
the
dev/atomic-putifabsent
branch
from
e9c830b to
4a71ca2
Compare
mp911de
added a commit
that referenced
this pull request
Jul 31, 2020
Simplify Expiration.from(…) construction. Original pull request: #553.
mp911de
added a commit
that referenced
this pull request
Jul 31, 2020
Simplify Expiration.from(…) construction. Original pull request: #553.
mp911de
added a commit
that referenced
this pull request
Jul 31, 2020
Simplify Expiration.from(…) construction. Original pull request: #553.
|
Thank you for your contribution. That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.